[PATCH] D129142: [LLD][ELF] Drop duplicates from rpath

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Thanks. This should be fine as it doesn't add many lines. Does this change the behavior in any way?



================
Comment at: lld/test/ELF/rpath.test:2
+# REQUIRES: x86
+// RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
+// RUN: ld.lld %t.o -rpath=/path1 -rpath=/path12 -rpath=/path2 -rpath=/path2 -rpath=/path1 -shared -o %t
----------------
Use `#`

`-triple=x86_64`


================
Comment at: lld/test/ELF/rpath.test:3
+// RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
+// RUN: ld.lld %t.o -rpath=/path1 -rpath=/path12 -rpath=/path2 -rpath=/path2 -rpath=/path1 -shared -o %t
+// RUN: llvm-readobj --dynamic-table %t | FileCheck %s
----------------
You may change some `-rpath` to `-rpath `



================
Comment at: lld/test/ELF/rpath.test:6
+
+// Degenerate case where an -rpath argument already contains a colon:
+// RUN: ld.lld %t.o -rpath=/path1 -rpath=/path1:/path2 -rpath=/path2 -shared -o %t
----------------
`## ` for non-directive (CHECK, RUN, etc) comments.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129142/new/

https://reviews.llvm.org/D129142