[PATCH] D129120: ManagedStatic: remove many straightforward uses in llvm

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:10741
+    sys::SmartScopedLock<true> Lock(VTMutex);
+    return &(*EVTs.insert(VT).first);
   }
----------------
This Mutex usage is dubious; at best this leaks memory; at worst, it's a miscompile waiting to happen.

Granted, that's true even without this patch...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129120/new/

https://reviews.llvm.org/D129120