[PATCH] D128934: [X86] Add RDPRU instruction
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 5 10:31:57 PDT 2022
probinson marked an inline comment as done.
probinson added a comment.
In D128934#3629653 <https://reviews.llvm.org/D128934#3629653>, @pengfei wrote:
> 1. Update ReleaseNotes;
Done, thanks for the reminder!
> 2. Update `clang/lib/Headers/cpuid.h` and `llvm/lib/Support/Host.cpp` if there's a new bit for it;
Not done; I had considered this, but the bit lives in a CPUID leaf that is not currently supported at all by the header or Host.cpp. I'm willing to add RDPRU, with FIXMEs for the other feature bits, if people want it.
> 3. Add macro test in `clang/test/Preprocessor/x86_target_features.c`
Done. For some reason I thought the clang intrinsic test would verify this, but actually it doesn't.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128934/new/
https://reviews.llvm.org/D128934
More information about the llvm-commits
mailing list