[PATCH] D125680: Correctly legalise stackmap operands

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:4675-4676
+      Res = MaybeRes.getValue();
+    else
+      goto fail;
+    break;
----------------
vext01 wrote:
> arsenm wrote:
> > Don't see why you are introducing this goto
> It's because it's the only path to the error state contained in the `default` branch of the switch.
> 
> In an earlier conversation we said that we wanted to trigger the default "can't legalise this" error if we encounter a case we cannot handle.
But there's no actual failure case here so I don't understand what this is doing. This is always producing something


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125680/new/

https://reviews.llvm.org/D125680