[PATCH] D129147: [llvm][AArch64] Fix "+all" feature for sysreg aliases

[David Spickett via Phabricator via llvm-commits]

DavidSpickett updated this revision to Diff 442328.
DavidSpickett added a comment.

clang-format


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129147/new/

https://reviews.llvm.org/D129147

Files:
  llvm/lib/Target/AArch64/Utils/AArch64BaseInfo.h
  llvm/test/MC/Disassembler/AArch64/mattr-all.txt


Index: llvm/test/MC/Disassembler/AArch64/mattr-all.txt
===================================================================
--- llvm/test/MC/Disassembler/AArch64/mattr-all.txt
+++ llvm/test/MC/Disassembler/AArch64/mattr-all.txt
@@ -35,3 +35,7 @@
 ## armv9a rme
 # CHECK: mrs x0, MFAR_EL3
 [0xa0,0x60,0x3e,0xd5]
+
+## predres (to make sure sysreg aliases work)
+# CHECK: cfp rctx, x0
+[0x80,0x73,0x0b,0xd5]
Index: llvm/lib/Target/AArch64/Utils/AArch64BaseInfo.h
===================================================================
--- llvm/lib/Target/AArch64/Utils/AArch64BaseInfo.h
+++ llvm/lib/Target/AArch64/Utils/AArch64BaseInfo.h
@@ -343,7 +343,8 @@
       : Name(N), Encoding(E), FeaturesRequired(F) {}
 
   bool haveFeatures(FeatureBitset ActiveFeatures) const {
-    return (FeaturesRequired & ActiveFeatures) == FeaturesRequired;
+    return ActiveFeatures[llvm::AArch64::FeatureAll] ||
+           (FeaturesRequired & ActiveFeatures) == FeaturesRequired;
   }
 
   FeatureBitset getRequiredFeatures() const { return FeaturesRequired; }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129147.442328.patch
Type: text/x-patch
Size: 1043 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220705/27f69cbc/attachment.bin>