[PATCH] D128029: [AArch64] Add target feature "all"

[David Spickett via Phabricator via llvm-commits]

DavidSpickett added a comment.

Thanks for implementing this!

I've been trying to use it in lldb's disassembler and found that for the "predres" extension +all doesn't work as expected.

  $ ./bin/llvm-mc --triple aarch64 --assemble -o - -mattr=+all --show-encoding <<< "cfp rctx, x0"
          .text
  <stdin>:1:5: error: CFPRCTX requires: predres
  cfp rctx, x0
      ^

I think I know what causes this and it's that `AArch64AsmParser::parseSysAlias` uses the feature bits from the SubTargetInfo. This is before "+all" has set all the other feature bits. It should be using the feature bits stored in the AsmParser, so I'm looking at changing it to do that.

Anything that isn't a sys instruction alias is fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128029/new/

https://reviews.llvm.org/D128029