[PATCH] D128192: [GlobalISel][DebugInfo] Propagate debug location for localized constants

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/Localizer.cpp:182
     MI->removeFromParent();
-    MBB.insert(II, MI);
+    auto NewMI = MBB.insert(II, MI);
     Changed = true;
----------------
Isn't NewMI the same as MI?


================
Comment at: llvm/lib/CodeGen/GlobalISel/Localizer.cpp:191
+
+      if (!(DefDL && DefDL.getLine() != 0) && UserDL && UserDL.getLine() != 0) {
+        NewMI->setDebugLoc(UserDL);
----------------
demorgan this?


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/localizer-propagate-debug-loc.mir:13-36
+    %1 = alloca i32, align 4
+    br i1 false, label %2, label %4
+
+  2:                                                ; preds = %0
+    %3 = load i32, ptr @A, align 4, !dbg !10
+    store volatile i32 %3, ptr %1, align 4
+    br label %9
----------------
Don't really need the function body if you remove the block names


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/localizer-propagate-debug-loc.mir:69
+tracksRegLiveness: true
+registers:
+  - { id: 0, class: gpr, preferred-register: '' }
----------------
Don't need registers section


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128192/new/

https://reviews.llvm.org/D128192