[PATCH] D129086: [NFC][AMDGPU] Cleanup the SIOptimizeExecMasking pass.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 5 08:42:08 PDT 2022


foad added a comment.

Looks OK to me.



================
Comment at: llvm/lib/Target/AMDGPU/SIOptimizeExecMasking.cpp:24
 class SIOptimizeExecMasking : public MachineFunctionPass {
+  MachineFunction *Func = nullptr;
+  const GCNSubtarget *ST = nullptr;
----------------
I have a slight preference for calling this field "MF" even if it makes runOnMachineFunction a little uglier.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129086/new/

https://reviews.llvm.org/D129086



More information about the llvm-commits mailing list