[PATCH] D125680: Correctly legalise stackmap operands
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 5 08:34:44 PDT 2022
arsenm added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:4675-4676
+ Res = MaybeRes.getValue();
+ else
+ goto fail;
+ break;
----------------
Don't see why you are introducing this goto
================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:5507
+
+Optional<SDValue> DAGTypeLegalizer::ExpandIntOp_STACKMAP(SDNode *N,
+ unsigned OpNo) {
----------------
Don't see why you're using Optional. Just use SDValue() like everything else?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125680/new/
https://reviews.llvm.org/D125680
More information about the llvm-commits
mailing list