[PATCH] D129084: [AMDGPU] gfx11 Fix disassembler for VOP3 dpp8

Tue Jul 5 08:31:52 PDT 2022

Joe_Nash requested changes to this revision.
Joe_Nash added a comment.
This revision now requires changes to proceed.

I agree with the problem description in the commit message, but I'm not sure this patch fully fixes the problem. There are no tests actually using the op_sel operand. I think those tests would reveal that the op_sel value is not being propagated from src_modifiers to the op_sel operand. We will need something similar to convertVOP3PDPPInst
In addition, OPSEL[1:0] are ignored by the hardware for these instructions. That should be reflected in the instruction definition. If it doesn't impact the dpp implementation, it could be a separate patch.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129084/new/

https://reviews.llvm.org/D129084