[PATCH] D129117: ManagedStatic: eliminate uses for cl::opt in the llvm directory

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 5 02:14:42 PDT 2022


nhaehnle created this revision.
nhaehnle added reviewers: efriedma, lattner.
Herald added subscribers: bzcheeseman, rriddle, hiraditya.
Herald added a project: All.
nhaehnle requested review of this revision.
Herald added a subscriber: stephenneuendorffer.
Herald added a project: LLVM.

Bring those uses more in line with the pattern used in MLIR, i.e.
pack the cl::opts into a struct. We avoid ManagedStatic entirely by then
instantiating that struct as a static function variable.

Remove additional uses of ManagedStatic in the affected files at the
same time.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D129117

Files:
  llvm/lib/Support/Debug.cpp
  llvm/lib/Support/GraphWriter.cpp
  llvm/lib/Support/RandomNumberGenerator.cpp
  llvm/lib/Support/Signals.cpp
  llvm/lib/Support/Timer.cpp
  llvm/lib/Support/TypeSize.cpp
  llvm/lib/Support/Unix/Signals.inc
  llvm/lib/Support/WithColor.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129117.442216.patch
Type: text/x-patch
Size: 26248 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220705/dfd1bccc/attachment.bin>


More information about the llvm-commits mailing list