[PATCH] D128890: [InstCombine] remove useless insertelement

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp:250
+      // once scale vectors are supported
+      if (X->hasOneUse() && Ext.getVectorOperand()->hasOneUse()) {
+        Value *NewBC = Builder.CreateBitCast(Vec, Ext.getVectorOperandType());
----------------
Are there tests for multiuse?


================
Comment at: llvm/test/Transforms/InstCombine/vscale_extractelement-inseltpoison.ll:44
 
-; TODO: Instcombine could remove the insert.
 define i8 @extractelement_bitcast_wrong_insert(<vscale x 2 x i32> %a, i32 %x) {
 ; CHECK-LABEL: @extractelement_bitcast_wrong_insert(
----------------
technically its not a wrong insert - 'useless' might be a better term!


================
Comment at: llvm/test/Transforms/InstCombine/vscale_extractelement.ll:44
 
-; TODO: Instcombine could remove the insert.
 define i8 @extractelement_bitcast_wrong_insert(<vscale x 2 x i32> %a, i32 %x) {
 ; CHECK-LABEL: @extractelement_bitcast_wrong_insert(
----------------
technically its not a wrong insert - 'useless' might be a better term!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128890/new/

https://reviews.llvm.org/D128890