[PATCH] D129059: [lld-macho] Handle LOH_ARM64_ADRP_LDR_GOT optimization hints

[Daniel Bertalan via Phabricator via llvm-commits]

This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
BertalanD marked 2 inline comments as done.
Closed by commit rG2028fe6fbca6: [lld-macho] Handle LOH_ARM64_ADRP_LDR_GOT optimization hints (authored by BertalanD).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Changed prior to commit:
  https://reviews.llvm.org/D129059?vs=442007&id=442177#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129059/new/

https://reviews.llvm.org/D129059

Files:
  lld/MachO/Arch/ARM64.cpp
  lld/test/MachO/loh-adrp-ldr-got.s


Index: lld/test/MachO/loh-adrp-ldr-got.s
===================================================================
--- /dev/null
+++ lld/test/MachO/loh-adrp-ldr-got.s
@@ -0,0 +1,35 @@
+# REQUIRES: aarch64
+
+# RUN: rm -rf %t; split-file %s %t
+# RUN: llvm-mc -filetype=obj -triple=arm64-apple-darwin %t/obj.s -o %t/obj.o
+# RUN: llvm-mc -filetype=obj -triple=arm64-apple-darwin %t/dylib.s -o %t/dylib.o
+# RUN: %lld -arch arm64 -dylib -o %t/libdylib.dylib %t/dylib.o
+# RUN: %lld -arch arm64 %t/obj.o %t/libdylib.dylib -o %t/AdrpLdrGot
+# RUN: llvm-objdump -d --macho %t/AdrpLdrGot | FileCheck %s
+
+#--- obj.s
+.text
+.globl _main
+# CHECK-LABEL: _main:
+_main:
+## The referenced symbol is local
+L1: adrp x0, _local at GOTPAGE
+L2: ldr  x0, [x0, _local at GOTPAGEOFF]
+# CHECK-NEXT: adr x0
+# CHECK-NEXT: nop
+
+## The referenced symbol is in a dylib
+L3: adrp x1, _external at GOTPAGE
+L4: ldr  x1, [x1, _external at GOTPAGEOFF]
+# CHECK-NEXT: nop
+# CHECK-NEXT: ldr x1
+
+_local:
+  nop
+
+.loh AdrpLdrGot L1, L2
+.loh AdrpLdrGot L3, L4
+
+#--- dylib.s
+.globl _external
+_external:
Index: lld/MachO/Arch/ARM64.cpp
===================================================================
--- lld/MachO/Arch/ARM64.cpp
+++ lld/MachO/Arch/ARM64.cpp
@@ -189,6 +189,7 @@
   void applyAdrpAdd(const OptimizationHint &);
   void applyAdrpAdrp(const OptimizationHint &);
   void applyAdrpLdr(const OptimizationHint &);
+  void applyAdrpLdrGot(const OptimizationHint &);
 
 private:
   uint8_t *buf;
@@ -424,6 +425,19 @@
   writeLiteralLdr(buf + hint.offset0 + hint.delta[0], ldr, delta);
 }
 
+// GOT loads are emitted by the compiler as a pair of adrp and ldr instructions,
+// but they may be changed to adrp+add by relaxGotLoad(). This hint performs
+// the AdrpLdr or AdrpAdd transformation depending on whether it was relaxed.
+void OptimizationHintContext::applyAdrpLdrGot(const OptimizationHint &hint) {
+  uint32_t ins2 = read32le(buf + hint.offset0 + hint.delta[0]);
+  Add add;
+  Ldr ldr;
+  if (parseAdd(ins2, add))
+    applyAdrpAdd(hint);
+  else if (parseLdr(ins2, ldr))
+    applyAdrpLdr(hint);
+}
+
 void ARM64::applyOptimizationHints(uint8_t *buf, const ConcatInputSection *isec,
                                    ArrayRef<uint64_t> relocTargets) const {
   assert(isec);
@@ -452,7 +466,7 @@
       ctx1.applyAdrpAdd(hint);
       break;
     case LOH_ARM64_ADRP_LDR_GOT:
-      // TODO: Implement this as well
+      ctx1.applyAdrpLdrGot(hint);
       break;
     }
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129059.442177.patch
Type: text/x-patch
Size: 2466 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220705/ee85f059/attachment.bin>