[PATCH] D128430: [LoongArch] Support lowering FrameIndex

Mon Jul 4 22:20:48 PDT 2022

SixWeining added a comment.

In D128430#3629155 <https://reviews.llvm.org/D128430#3629155>, @xen0n wrote:

> LGTM apart from the stack ID assertion bit; @SixWeining do you think an assertion should be present nevertheless even if we're only using one type of stack currently?

I think either is fine. I think the reason RISCV does an assertion is that it sets non-default stack ID in its .cpp code.
Considering LoongArch currently only use default stack ID which is not set by target explicitly, maybe there is no strong reason to do an assertion.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128430/new/

https://reviews.llvm.org/D128430