[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

Mon Jul 4 05:21:40 PDT 2022

pengfei added a comment.

In D107082#3628120 <https://reviews.llvm.org/D107082#3628120>, @sylvestre.ledru wrote:

> @pengfei I am not convinced it is an issue on my side. I don't have anything particular in this area and using a stage2 build system.
>
> Anyway, this patch fixes the issue on my side:
> https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/-/blob/snapshot/debian/patches/force-sse2-compiler-rt.diff

I don't have much experience in compiler-rt and multi stage build. So I may be wrong. It looks to me like an existing problem just exposed by this patch. The diff is another proof.
The build command tells us it's a 32-bit build. But the change for `x86_64` solves it, which confirms my previous guess: You are using one configure for CMake (probobally 64 bit) but build for 32 bit target.
Although the diff works, it doesn't look a clean solution to me. But I don't have better suggestion either.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107082/new/

https://reviews.llvm.org/D107082