[PATCH] D129052: [Object] Add ELF section type for offloading objects

Mon Jul 4 04:52:26 PDT 2022

jhuber6 added a comment.

In D129052#3628182 <https://reviews.llvm.org/D129052#3628182>, @jhenderson wrote:

> I'm just trying to understand the test coverage, because I'm not too familiar with the touched areas of code:
>
> 1. `CodeGen/TargetLoweringObjectFileImpl.cpp` is covered by `CodeGen/X86/offload_sections.ll`? (CodeGen converts named section type to ELF type)
> 2. `MCParser/ELFAsmParser.cpp` is covered by `MC/AsmParser/llvm_section_types.s` (llvm-mc can understand the section directive)
> 3. `MCSectionELF.cpp` is covered by `CodeGen/X86/offload_sections.ll`? (Code converts ELF type for section directive)
> 4. `Object/ELF.cpp` is covered by `MC/AsmParser/llvm_section_types.s` (llvm-readobj recognises the section type)
> 5. `ObjectYAML/ELFYAML.cpp` is covered by `ObjectYAML/ELF/sht-offloading.yaml`
>
> Does this line up with your expectation? If so, LGTM. (If not, please could you explain where it doesn't!)

Yes, that sounds right. Thanks for the reviews

In D129052#3628186 <https://reviews.llvm.org/D129052#3628186>, @jhenderson wrote:

> Addendum: it might be worth getting somebody else to chime in on the CodeGen change before landing this.

Yes, I would like to get some feedback on if I should go with some metadata attached to the generated global to determine if it should be at this section. I mainly want this so I can decide whether or not this section should have `SHF_EXCLUDE` or not.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129052/new/

https://reviews.llvm.org/D129052