[PATCH] D127611: [ELF] Relax R_RISCV_CALL and R_RISCV_CALL_PLT
Luís Marques via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jul 3 07:26:01 PDT 2022
luismarques accepted this revision.
luismarques added a comment.
My tests finally finished running. No issues detected. LGTM.
================
Comment at: lld/test/ELF/riscv-relax-call.s:121
+.section .high,"ax", at progbits
+ call _start at plt # relaxable for 32c
+ call _start at plt # not relaxed
----------------
Nit: "32c" is confusing. "RV32C" is the usual name.
================
Comment at: lld/test/ELF/riscv-relax-call.s:134
+ .mid 0x10800 : { *(.mid) }
+ # 22 is the size of _start in 32c (RVC32).
+ .high 0x110000+(_start_end-_start)-22 : { *(.high) }
----------------
Nit: just write "RV32C" instead of "32c (RVC32)"?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127611/new/
https://reviews.llvm.org/D127611
More information about the llvm-commits
mailing list