[PATCH] D128430: [LoongArch] Support lowering FrameIndex

[WÁNG Xuěruì via Phabricator via llvm-commits]

xen0n added a comment.

The other changes look good.



================
Comment at: llvm/lib/Target/LoongArch/LoongArchFrameLowering.cpp:68-69
+  int MaxCSFI = -1;
+  StackOffset Offset =
+      StackOffset::getFixed(MFI.getObjectOffset(FI) - getOffsetOfLocalArea() +
+                            MFI.getOffsetAdjustment());
----------------
This implementation is a simplified version of RISCV's `getFrameIndexReference`, but we're missing a stack ID check before this. I know we're not utilizing any non-default stack IDs so far but I don't know if such a check/assertion should be kept anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128430/new/

https://reviews.llvm.org/D128430