[PATCH] D128968: [JITLink][COFF] Initial COFF support.

[Peter S. Housel via Phabricator via llvm-commits]

housel added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.cpp:136
+      GraphSec = &G->createSection(SectionName, Prot);
+    assert(GraphSec->getMemProt() == Prot && "MemProt should match");
+
----------------
Maybe this should be an error return rather than an assert


================
Comment at: llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.cpp:414
+// symbol which contains the size and name of the section. It also contains
+// selectino type that specifies how duplicates of the symbol is handled.
+// Second symbol is COMDAT symbol which usually defines the external name and
----------------
contains a selection type... are handled


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128968/new/

https://reviews.llvm.org/D128968