[PATCH] D128428: [LoongArch] Add codegen support for conditional branches

[WÁNG Xuěruì via Phabricator via llvm-commits]

xen0n accepted this revision.
xen0n added a comment.
This revision is now accepted and ready to land.

Someone else more familiar with LLVM internals could teach us about that particular tblgen behavior noted above, but the rest LGTM.



================
Comment at: llvm/test/CodeGen/LoongArch/ir-instruction/br.ll:21
+; LA32-NEXT:    beq $a2, $a0, .LBB1_2
+; LA32-NEXT:    b .LBB1_1
+; LA32-NEXT:  .LBB1_1: # %test
----------------
wangleiat wrote:
> xen0n wrote:
> > Why this redundant unconditional jump? Is it because optimization is not enabled or other reason?
> We will implement overloading of the public function interface in later patches to eliminate unnecessary branches. 
> For example: `TargetInstrInfo::analyzeBranch`
Fair enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128428/new/

https://reviews.llvm.org/D128428