[PATCH] D128427: [LoongArch] Add codegen support for load/store operations

Ray Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 1 18:54:22 PDT 2022


wangleiat added a comment.

In D128427#3624889 <https://reviews.llvm.org/D128427#3624889>, @xen0n wrote:

> While I'm not very sure about the new `pcalau12i + addi` symbol address materialization, they look good regardless, so are the other test cases.
>
> Do you think a test exercising very large offset for `getelementptr` is worthwhile? LGTM otherwise.

Thanks!
The large offset situation can be covered in previous patches, offsets will be converted to immediate loads.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128427/new/

https://reviews.llvm.org/D128427



More information about the llvm-commits mailing list