[PATCH] D127158: [AArch64] Add intrinsic support for gpr<->fpr flavors of fixed-point converts
Rob McClure via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 1 15:08:05 PDT 2022
rmcclure added a comment.
Ping! Any further thoughts on this change? To summarize the opens:
1. arm64-fixed-point-scalar-cvt-dagcombine.ll has a failure because we now select a different flavor of the convert than the test expects. My plan here would be to temporarily disable the test, and submit a subsequent change that lets LLVM select the ~best flavor depending on which register file the inputs/outputs prefer to be in
2. This technically violates the ACLE spec for these intrinsics. I believe the ACLE spec should be changed, but since LLVM already violates the spec for the int <-> fp converts, I don't believe that this change should be gated by the ACLE spec change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127158/new/
https://reviews.llvm.org/D127158
More information about the llvm-commits
mailing list