[PATCH] D129017: [fpcmp] Use non-floating point parsing by default.

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 1 14:54:57 PDT 2022


Meinersbur created this revision.
Meinersbur added reviewers: rovka, MatzeB.
Herald added a subscriber: mgorny.
Herald added a project: All.
Meinersbur requested review of this revision.

Unless using the `-a` or `-r` options, do not parse floating point numbers in order to compare its numeric difference. Despite its name, `fpcmp` used used to compare every program output with its reference output even for programs that do not handle floating point and caused `0.` and `0` to be always considered equal.

I the old behaviour is needed (as for the TSVC benchmark), floating point comparison with zero numeric tolerance can be enabled by explicitly setting `-a 0` or `-r 0`.

Motivated by D128262 <https://reviews.llvm.org/D128262>.


Repository:
  rT test-suite

https://reviews.llvm.org/D129017

Files:
  MultiSource/Benchmarks/TSVC/CMakeLists.txt
  tools/fpcmp.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129017.441788.patch
Type: text/x-patch
Size: 4280 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220701/3ddfd8bd/attachment.bin>


More information about the llvm-commits mailing list