[PATCH] D128913: [IR] Have Value::takeName() transfer intrinsic properties

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 1 14:00:44 PDT 2022


aeubanks added a comment.

was worried about compile time issues, seems fine
https://llvm-compile-time-tracker.com/compare.php?from=a9119143a2d1f4d0d0bc1fe0d819e5351b4e0deb&to=3262dfdab15c7017935961c06b127ec9ac8dc7fd&stat=instructions

I'd sort of prefer going the opposite route of https://reviews.llvm.org/D129015 and banning `setName`/`takeName` on intrinsics, that seems less error-prone
it seems weird to create a new intrinsic declaration that has the same name as a previous intrinsic


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128913/new/

https://reviews.llvm.org/D128913



More information about the llvm-commits mailing list