[PATCH] D128670: [SimplifyCFG] teach simplifycfg not to introduce ptrtoint for NI pointers

Jameson Nash via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 1 11:55:49 PDT 2022


vtjnash added inline comments.


================
Comment at: llvm/test/Transforms/SimplifyCFG/nonintegral.ll:2
+; RUN: opt -simplifycfg -verify -S < %s | FileCheck %s
+; RUN: opt -passes=simplifycfg,verify -S < %s | FileCheck %s
+
----------------
nikic wrote:
> Explicit verify is unnecessary. First RUN line can be dropped, they do the same thing. Please use update_test_checks.py.
I used update_test_checks.py to generate these tests, but disliked the results, and edited them to the form here. Has policy changed such that it is now required to be used verbatim?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128670/new/

https://reviews.llvm.org/D128670



More information about the llvm-commits mailing list