[PATCH] D128433: [LoongArch] Add LoongArch support to update_llc_test_checks

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/loongarch_function_name.ll:2
+; Check that we accept functions with '$' in the name.
+;
+; RUN: llc -mtriple=loongarch32-unknown-linux < %s | FileCheck %s
----------------
xen0n wrote:
> MaskRay wrote:
> > xen0n wrote:
> > > MaskRay wrote:
> > > > The convention does not add otherwise empty `;`
> > > You mean that by convention this line should be removed? I grepped the nearby test cases but it seems most are actually including these `;` lines.
> > They deviate from the convention. I will remove them
> Hmm it may be appropriate for the patch author to rebase after your cleanup lands then; otherwise I fear introducing local inconsistency just for being consistent with a future change.
removed 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128433/new/

https://reviews.llvm.org/D128433