[PATCH] D127392: [InstCombine] Combine consecutive loads which are being merged to form a wider load.

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In D127392#3625257 <https://reviews.llvm.org/D127392#3625257>, @nikic wrote:

> When switching this to AggressiveInstCombine, I would strongly recommend to start with a much more minimal patch. Handle only a single simple case, without any of the possible variants. We can build on that base later.

Strongly agree - there's a lot of potential for this to go wrong both in correctness and perf regressions, so we need to build up in steps. 
AFAIK, the load combine pass did not have correctness problems when it died, so that source code would be a good reference.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127392/new/

https://reviews.llvm.org/D127392