[PATCH] D127990: [DirectX] add thread/group id DXIL operations.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

I don't know the format, so I just make some random style related comments.



================
Comment at: llvm/test/CodeGen/DirectX/comput_ids.ll:8
+
+; CHECK-LABEL:test_thread_id
+; Function Attrs: noinline nounwind optnone
----------------
Ensure `@` and `(` are present.


================
Comment at: llvm/test/CodeGen/DirectX/comput_ids.ll:12
+entry:
+; CHECK:call i32 @dx.op.threadId.i32(i32 93, i32 %{{.*}})
+  %0 = call i32 @llvm.dxil.thread.id(i32 %a)
----------------
add a space after `:`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127990/new/

https://reviews.llvm.org/D127990