[PATCH] D129004: [Support] Fix Windows dump file hang with multi-threaded crashes

[Andrew Ng via Phabricator via llvm-commits]

andrewng created this revision.
andrewng added reviewers: lenykholodov, rnk, aganea.
Herald added subscribers: hiraditya, mgorny.
Herald added a project: All.
andrewng requested review of this revision.
Herald added a project: LLVM.

Prevents deadlock between MiniDumpWriteDump and
CryptAcquireContextW (called via fs::createTemporaryFile) in
WriteWindowsDumpFile.

However, there's no guarantee that deadlock can't still occur between
MiniDumpWriteDump and some other Win32 API call. But that would appear
to be the "accepted" risk of using MiniDumpWriteDump in this manner.


https://reviews.llvm.org/D129004

Files:
  llvm/lib/Support/Windows/Signals.inc
  llvm/unittests/Support/CMakeLists.txt
  llvm/unittests/Support/WindowsDumpFileTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129004.441722.patch
Type: text/x-patch
Size: 4701 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220701/798c162b/attachment.bin>