[PATCH] D128261: [Fortran] Relax relative tolerance for FCVS tests

Fri Jul 1 08:52:26 PDT 2022

klausler added a comment.

In D128261#3624481 <https://reviews.llvm.org/D128261#3624481>, @rovka wrote:

> Right, sorry, I don't know why the other change disappeared. It should be back now.
> Regarding the other tests, AFAICT they don't use list-directed or NAMELIST output, so having stricter checks might (?) actually catch real problems. But really I don't know much about the subtleties of Fortran FP formats. @klausler Should we update the tolerance for all tests now or wait and treat each issue we might run into separately?

You should capture the current f18 output and require exact matching, with no allowance for floating-point (or other) differences.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128261/new/

https://reviews.llvm.org/D128261