[PATCH] D128591: Transforms: Relax restrictions on pow(x, y) expansion

Fri Jul 1 08:22:55 PDT 2022

pawosm01 added a comment.

Hi @RKSimon, thanks for your comments, although I'd like to obtain some of your guidance on what can I do to address them in the context of this commit.

> It seems problematic that LibCallSimplifier::optimizePow also folds pow ->powi yet we also have pow expansion code that is completely separate from powi (where its handled in CGP).

Does it mean that in order to make things less problematic, all applications of createPowWithIntegerExponent() should be moved somewhere else? Or maybe `pow`/`powf`/`powl` expansion code should not occur in optimizePow()? Should the scope of this commit be extended towards such refactor?

> We now have TTI:isBeneficialToExpandPowI to decide when to expand powi intrinsics properly instead of hard coded limits like there are here.

Should it happen the same way for `pow`/`powf`/`powl` too?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128591/new/

https://reviews.llvm.org/D128591