[PATCH] D128719: [IR] Remove support for insertvalue constant expression

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 1 07:39:16 PDT 2022


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM

In D128719#3615870 <https://reviews.llvm.org/D128719#3615870>, @nikic wrote:

> In D128719#3615789 <https://reviews.llvm.org/D128719#3615789>, @reames wrote:
>
>> Don't we have to worry about forward compatibility with bitcode on this one?  I didn't see anything for that in this change?
>
> `insertvalue` is another expression not supported in bitcode. It's the last one though, other ones will need the bitcode part.

Please update your submission comment to include this information.  It's important for review - including post commit review.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128719/new/

https://reviews.llvm.org/D128719



More information about the llvm-commits mailing list