[PATCH] D127947: [AST] Don't assert instruction reads/writes memory (PR51333)

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 1 07:21:46 PDT 2022


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks! Handling instructions not accessing memory should be fine there and pushing the responsibility to remove MemmoryDefs that become non-defs to transforms making changes seems unnecessarily strict.



================
Comment at: llvm/test/Transforms/LICM/pr51333.ll:23
+do.body:
+  store void ()* @readnone_fn, void ()** @fn_ptr
+  %fn = load void ()*, void ()** @fn_ptr
----------------
can this use opaque pointers?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127947/new/

https://reviews.llvm.org/D127947



More information about the llvm-commits mailing list