[PATCH] D128959: [llvm-objdump] -r: print non-SHF_ALLOC relocations for non-ET_REL files

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Looks good with 2 nits.



================
Comment at: llvm/test/tools/llvm-objdump/ELF/relocations-in-nonreloc.test:3-8
+# RUN: yaml2obj --docnum=1 -DTYPE=ET_EXEC %s -o %t1
+# RUN: llvm-objdump -r %t1 | FileCheck %s -DFILE=%t1
+# RUN: yaml2obj --docnum=1 -DTYPE=ET_DYN %s -o %t2
+# RUN: llvm-objdump -r %t2 | FileCheck %s -DFILE=%t2
+# RUN: yaml2obj --docnum=1 -DTYPE=ET_REL %s -o %t3
+# RUN: llvm-objdump -r %t3 | FileCheck %s -DFILE=%t3
----------------
Nits: 1) you've only got one YAML block, so you don't need the --docnum option. 2) If the third case is just to sanity check the dumping matches, you should consider adding an additional comment to note this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128959/new/

https://reviews.llvm.org/D128959