[PATCH] D127202: [InlineFunction] don't add noalias metadata for unknown objects

Thu Jun 30 23:38:54 PDT 2022

shchenz marked an inline comment as done.
shchenz added inline comments.

================
Comment at: llvm/test/Transforms/Inline/inline-noalias-unidentify-object.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
 ; RUN: opt < %s -passes=inline -enable-noalias-to-md-conversion -S | FileCheck %s

----------------
jeroen.dobbelaere wrote:
> You'll need to add the option to check full lines, otherwise the check on line 17 (store i32...) will still match a store containing a noalias
92a3e1b5c9e7ddd1b981393eac391a3745eff9a8 is committed to address this comment.

Sorry, I didn't noticed this comment when I committed the patch, seems we are almost at the same time : )

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127202/new/

https://reviews.llvm.org/D127202