[PATCH] D128148: [XCOFF] write the aux header when the visibility is specified in XCOFF32.

[Esme Yi via Phabricator via llvm-commits]

Esme added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:783
+  W.write<uint32_t>(0);  // TextStartAddr
+  W.write<uint32_t>(0);  // DataStartAddr
+}
----------------
DiggerLin wrote:
> since we can know the address and Size from stuct SectionEntry , do you want to put the value here instead of zero?
I may prefer to post another patch for calculating the start addresses and the total sizes for Text/Data/BSS sections since this patch comes from the visibility requirement and these fields are not required.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128148/new/

https://reviews.llvm.org/D128148