[PATCH] D127835: [SCEV] recognize llvm.annotation intrinsic

Thu Jun 30 20:06:51 PDT 2022

shchenz added inline comments.

================
Comment at: llvm/docs/LangRef.rst:23618-23619
 optimizations that want to look for these annotations. These have no
-other defined use; they are ignored by code generation and optimization.
+other defined use; they are replaced with their first operand in instruction
+selection passes and in all other transformations and analysis.

----------------
Meinersbur wrote:
> This sounds like they are removed immediately (even by analyses?), but its just that it is semantically correct to do so while losing some information such as debug info.
> 
> Could you use wording such as "transformations preserve annotations on a best-effort basis but are allowed to replace them with their first argument without breaking semantics and are completely dropped during instruction selection"?
Thanks. Updated.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127835/new/

https://reviews.llvm.org/D127835