[PATCH] D128544: [Orc][JITLink] Add a shared memory based implementation of MemoryMapper

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz added a comment.
Herald added a subscriber: ormris.

Thanks for posting your patch! I will continue reviewing, but here is a first detail I found..



================
Comment at: llvm/lib/ExecutionEngine/Orc/MemoryMapper.cpp:229
+      },
+      SAs.Instance, NumBytes);
+}
----------------
I had to cast this to `uint64_t` explicitly in order to fix a SPS encoding error. It appears the issue is that on my system `size_t` is `unsigned long` and not `unsigned long long`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128544/new/

https://reviews.llvm.org/D128544