[PATCH] D128944: [ms] [llvm-ml] Add support for anonymous labels (`@@`, `@B`, `@F`)

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

Should these be unnamed labels so they don't appear in the COFF file symbol table? I'm guessing ml64 doesn't produce symbols for these labels, but correct me if I'm wrong.

If that is the case, I suggest:

- keep the counter
- store a vector of MCSymbols indexed by label counter
- use a getOrCreate operation to fill in that vector or read from it to handle support for forward references (`@F`)



================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:406
 
-  /// Maps data location names to types.
   StringMap<AsmTypeInfo> KnownType;
----------------
Looks like an unintended change


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128944/new/

https://reviews.llvm.org/D128944