[PATCH] D128705: [llvm-objdump] Create fake sections for a ELF core file

[Namhyung Kim via Phabricator via llvm-commits]

namhyung marked an inline comment as not done.
namhyung added inline comments.


================
Comment at: llvm/include/llvm/Object/ELFObjectFile.h:264
   bool ContentValid = false;
+  bool FakeSectionsUsed = false;
 
----------------
namhyung wrote:
> jhenderson wrote:
> > I think this boolean is probably superfluous: you coudl check within `createFakeSections` whether the FakeSections vector is empty and just end early if it is.
> But the fake section vector is a private member of ELFFile so we cannot check it here.  Do you want me to add a public function in ELFFile to check it?
I'll just move the check to ELFFile.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128705/new/

https://reviews.llvm.org/D128705