[PATCH] D128934: [X86] Add RDPRU instruction

Thu Jun 30 12:23:00 PDT 2022

craig.topper added inline comments.

================
Comment at: llvm/lib/Target/X86/X86InstrSystem.td:742
+let Uses = [ECX], Defs = [EAX, EDX] in
+   def RDPRU : I<0x01, MRM_FD, (outs), (ins), "rdpru", []>, TB,
+               Requires<[HasRDPRU]>;
----------------
I think `TB` here should be `PS`. Per table "Table A-8. Opcode 01h ModRM Extensions", the instruction is not valid with a 0xF2 or 0xF3 prefix. `PS` is our marker for that.

================
Comment at: llvm/test/CodeGen/X86/rdpru.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+rdpru | FileCheck %s
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+rdpru -fast-isel | FileCheck %s
----------------
Add i686 command lines to test the ReplaceNodeResults code.

================
Comment at: llvm/test/MC/X86/x86-64.s:1581

+// CHECK: rdpru
+// CHECK:  encoding: [0x0f,0x01,0xfd]
----------------
Please add a disassembler test too.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128934/new/

https://reviews.llvm.org/D128934