[PATCH] D127037: [OpenMP][IRBuilder] 'omp target enter data' support.

[Valentin Clement via Phabricator via llvm-commits]

clementval requested changes to this revision.
clementval added inline comments.
This revision now requires changes to proceed.


================
Comment at: mlir/include/mlir/Target/LLVMIR/Dialect/Utils/CommonOpenMPOpenACCUtils.h:1
+//===- ReshapeOpsUtils.h - Utilities used by reshape ops --*- C++ -*------===//
+//
----------------
Update header


================
Comment at: mlir/include/mlir/Target/LLVMIR/Dialect/Utils/CommonOpenMPOpenACCUtils.h:19
+
+LogicalResult convertDataOp(acc::DataOp &op, llvm::IRBuilderBase &builder,
+                            LLVM::ModuleTranslation &moduleTranslation);
----------------
Is there something missing or do you want to support only `acc::DataOp`?


================
Comment at: mlir/lib/Target/LLVMIR/Dialect/Utils/CommonOpenMPOpenACCUtils.cpp:268
 /// Converts an OpenACC data operation into LLVM IR.
-static LogicalResult convertDataOp(acc::DataOp &op,
-                                   llvm::IRBuilderBase &builder,
-                                   LLVM::ModuleTranslation &moduleTranslation) {
+LogicalResult mlir::convertDataOp(acc::DataOp &op, llvm::IRBuilderBase &builder,
+                                  LLVM::ModuleTranslation &moduleTranslation) {
----------------
Since this is for `acc::DataOp` it should be in the OpenACC file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127037/new/

https://reviews.llvm.org/D127037