[PATCH] D128452: [LLVM][LTO][LLD] Enable Profile Guided Layout (--call-graph-profile-sort) for FullLTO (PR #56185)

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 30 12:04:33 PDT 2022


MaskRay accepted this revision.
MaskRay added a comment.

Thanks for the updated summary.

> https://github.com/llvm/llvm-project/issues/56185

You can use `Fix(es)? https://github.com/llvm/llvm-project/issues/56185` (or #56185) so that the pushed commit will close the issue automatically.

Since the body mentions the issue, you can remove ` (PR #56185)` from the subject.

> ThinLTO compilation at link time adds the CGProfilePass (see: buildModuleOptimizationPipeline).

This is incorrect for distributed ThinLTO which happens at `clang -fthinlto-index=...` time.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128452/new/

https://reviews.llvm.org/D128452



More information about the llvm-commits mailing list