[PATCH] D128934: [X86] Add RDPRU instruction

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 30 12:03:06 PDT 2022


probinson added a comment.

If this patch is too big, I'm happy to break it into two (LLVM/Clang) or 4 (piecemeal features) parts.

Two questions:

- Should the clang builtin be in BuiltinsX86_64.td instead of BuiltinsX86.td?  It's supported only by Zen.
- I didn't need to add a case for this in CGBuiltin.cpp, which was surprising; just adding the entry to BuiltinsX86.def was enough to automatically lower the Clang builtin to the IR intrinsic. Does that auto-magic mean there are cases that could be removed from CGBuiltin.cpp?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128934/new/

https://reviews.llvm.org/D128934



More information about the llvm-commits mailing list