[PATCH] D128030: [llvm-objdump] Default to --mattr=+all for AArch64

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1696-1698
+  } else if (MCPU.empty() && Obj->getArch() == llvm::Triple::aarch64) {
+    Features.AddFeature("+all");
+  }
----------------
nickdesaulniers wrote:
> Adding context to [[ https://reviews.llvm.org/D128029#3592359 | my comment ]], this is where I'd expect us to handle per-arch enabling of various target features.
> 
> ```
> ...
> if (MAttrs.empty() && MCPU.empty())
>   enableAllArchFeatures()
> ...
> 
> static void enableAllArchFeatures() {
>   switch (arch) {
>   case aarch64:
>     Features.AddFeature("+sve", etc etc);
>     break;
>   case x86:
> ...
> }
> ```
Resolved in D128029 ((a) Use TableGen to derive the source of truth. (b) The disassembler side just forwards "+all")


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128030/new/

https://reviews.llvm.org/D128030