[PATCH] D128911: Emit table lookup from TargetLowering::expandCTTZ()

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 30 07:56:06 PDT 2022


dmgreen added a comment.

Once you manage to get something that works, can you make sure you upload patches with full context as in https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface. It makes the reviews a lot easier to read.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:7845
+                  DAG.getConstant(0x077CB531U, dl, VT)),
+      DAG.getConstant(27, dl, VT));
+
----------------
gsocshubham wrote:
> Can anyone suggest how do I get reference to table here?
> 
> If I get a reference here then I can index into the table using above `Lookup`.
Eli had some comments in https://reviews.llvm.org/D113291#3540702. DAGCombiner:: convertSelectOfFPConstantsToLoadOffset has some code that emits a table.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128911/new/

https://reviews.llvm.org/D128911



More information about the llvm-commits mailing list