[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added inline comments.


================
Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:731
 
-  ModuleInlinerWrapperPass MIWP(
-      IP, PerformMandatoryInliningsFirst,
-      InlineContext{Phase, InlinePass::CGSCCInliner},
-      UseInlineAdvisor, MaxDevirtIterations);
+  ModuleInlinerWrapperPass MIWP(IP, PerformMandatoryInliningsFirst,
+                                InlineContext{Phase, InlinePass::CGSCCInliner},
----------------
are these changes due to running clang-format (i.e. the previous change didn't?)


================
Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1622
       InlineContext{ThinOrFullLTOPhase::FullLTOPostLink,
-                          InlinePass::CGSCCInliner}));
+                    InlinePass::CGSCCInliner}));
 
----------------
same clang-format q


================
Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1689
 
-
   if (EnableConstraintElimination)
----------------
spurious change?


================
Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1725
   // Run the OpenMPOpt CGSCC pass again late.
-  MPM.addPass(
-      createModuleToPostOrderCGSCCPassAdaptor(OpenMPOptCGSCCPass()));
+  MPM.addPass(createModuleToPostOrderCGSCCPassAdaptor(OpenMPOptCGSCCPass()));
 
----------------
was this clang-format?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128830/new/

https://reviews.llvm.org/D128830