[PATCH] D128442: [AMDGPU] GFX11: automatically release VGPRs at the end of the shader

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUReleaseVGPRs.cpp:57
+    // Use the cache to break infinite loop and save some time
+    if (BlockVMEMStore.count(&MBB) != 0)
+      return BlockVMEMStore[&MBB];
----------------
Try to insert and see if it failed?


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUReleaseVGPRs.cpp:65
+        BlockVMEMStore[&MBB] = true;
+        return true;
+      } else {
----------------
No else after return


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128442/new/

https://reviews.llvm.org/D128442