[PATCH] D128842: [InstrProf] Mark __llvm_profile_runtime hidden to match libclang_rt.profile definition

[Justin Cady via Phabricator via llvm-commits]

justincady added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:1247
                          nullptr, getInstrProfRuntimeHookVarName());
+  if (!TT.isOSWindows())
+    Var->setVisibility(GlobalValue::HiddenVisibility);
----------------
MaskRay wrote:
> Remove Windows special case. The visibility is a no-op on Windows.
Done, thank you. I was trying to match COMPILER_RT_VISIBILITY not setting visibility for Windows, but did not realize it isn't set because it's a no-op.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128842/new/

https://reviews.llvm.org/D128842