[PATCH] D128905: X86: don't fold swifterror load into anything

Tim Northover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 30 04:56:59 PDT 2022


t.p.northover created this revision.
Herald added subscribers: jsji, pengfei, hiraditya, mcrosier.
Herald added a project: All.
t.p.northover requested review of this revision.
Herald added a project: LLVM.

Swifterror loads aren't what they seem because there's an implicit mini-mem2reg that happens during ISel, effectively removing the stack slot from existence. So it shouldn't be folded into any other arithmetic by FastISel either.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D128905

Files:
  llvm/lib/Target/X86/X86FastISel.cpp
  llvm/test/CodeGen/X86/swifterror.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128905.441356.patch
Type: text/x-patch
Size: 5572 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220630/b0594e23/attachment.bin>


More information about the llvm-commits mailing list